Skip to content

[Cleanup] Filtering Active Payment Terms#3171

Merged
beganovich merged 4 commits into
invoiceninja:developfrom
Civolilah:cleanup/2313-payment-terms-list
Jun 2, 2026
Merged

[Cleanup] Filtering Active Payment Terms#3171
beganovich merged 4 commits into
invoiceninja:developfrom
Civolilah:cleanup/2313-payment-terms-list

Conversation

@Civolilah
Copy link
Copy Markdown
Collaborator

@beganovich @turbo124 The PR includes filtering active payment terms instead of displaying all of them for selectors. Let me know your thoughts.

@turbo124
Copy link
Copy Markdown
Member

this is better, but then it does lead to issues like this:

image

most likely this is just a compromise for the given issue we are dealing with here thou..

@Civolilah
Copy link
Copy Markdown
Collaborator Author

this is better, but then it does lead to issues like this:

image most likely this is just a compromise for the given issue we are dealing with here thou..

@turbo124 Okay, I understand the issue of duplicating payment terms with the same number of days. I have made a solution. Let me know your thoughts.

@turbo124
Copy link
Copy Markdown
Member

@Civolilah this reverts everything back to the precommit experience here.

For example, if I have a client with 30 day payment terms. Then Archive the 30 day option.

The clients option never appears in the selector.

image image

@Civolilah
Copy link
Copy Markdown
Collaborator Author

@Civolilah this reverts everything back to the precommit experience here.

For example, if I have a client with 30 day payment terms. Then Archive the 30 day option.

The clients option never appears in the selector.

image image

@turbo124 Ah okay, I got you. So, if a payment term is selected on a client and then archived/deleted, it will still appear in the dropdown. But if you go to any other client where that specific payment term is not selected or a different one is selected, it will not be displayed in the dropdown at all. Let me know your thoughts.

Copy link
Copy Markdown
Member

@beganovich beganovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@beganovich beganovich merged commit 33b4984 into invoiceninja:develop Jun 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants